Skip to content

gh-151845: Fix formatfloat() return-value contract in unicode_format.c#151846

Merged
sobolevn merged 1 commit into
python:mainfrom
aisk:fix-formatfloat-return-value
Jun 21, 2026
Merged

gh-151845: Fix formatfloat() return-value contract in unicode_format.c#151846
sobolevn merged 1 commit into
python:mainfrom
aisk:fix-formatfloat-return-value

Conversation

@aisk

@aisk aisk commented Jun 21, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

As mentioned in the issue, this don't affected to callers and users, so /skip-news and don't requires a test.

@bedevere-app bedevere-app Bot mentioned this pull request Jun 21, 2026
Closed
@aisk aisk added the skip news label Jun 21, 2026
@sobolevn

sobolevn commented Jun 21, 2026

Copy link
Copy Markdown
Member

Does it need to be backported?

@aisk

aisk commented Jun 21, 2026

Copy link
Copy Markdown
Member Author

This change doesn’t affect Python’s behavior because the caller already handles it. However, I think it would still be better to backport it to avoid potential future conflicts, as long as the backport is conflict-free.

@sobolevn sobolevn added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes needs backport to 3.15 pre-release feature fixes, bugs and security fixes labels Jun 21, 2026
@sobolevn sobolevn enabled auto-merge (squash) June 21, 2026 17:16
@sobolevn sobolevn merged commit c2661e6 into python:main Jun 21, 2026
147 of 151 checks passed
@miss-islington-app

miss-islington-app Bot commented Jun 21, 2026

Copy link
Copy Markdown

Thanks @aisk for the PR, and @sobolevn for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14, 3.15.
🐍🍒⛏🤖

@miss-islington-app

miss-islington-app Bot commented Jun 21, 2026

Copy link
Copy Markdown

Sorry, @aisk and @sobolevn, I could not cleanly backport this to 3.14 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker c2661e6189ab2833bf32fa723cc427e64c026839 3.14

@bedevere-app

bedevere-app Bot commented Jun 21, 2026

Copy link
Copy Markdown

GH-151865 is a backport of this pull request to the 3.15 branch.

@miss-islington-app

miss-islington-app Bot commented Jun 21, 2026

Copy link
Copy Markdown

Sorry, @aisk and @sobolevn, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker c2661e6189ab2833bf32fa723cc427e64c026839 3.13

@bedevere-app bedevere-app Bot removed the needs backport to 3.15 pre-release feature fixes, bugs and security fixes label Jun 21, 2026
@aisk

aisk commented Jun 21, 2026

Copy link
Copy Markdown
Member Author

Hi, since backporting this to 3.13 and 3.14 causes conflicts, I think we should just leave it as is.

@aisk aisk deleted the fix-formatfloat-return-value branch June 21, 2026 17:21
sobolevn pushed a commit that referenced this pull request Jun 21, 2026
@miss-islington @aisk
[3.15] gh-151845: Fix formatfloat() return-value contract in unicode_…
f5119a5 
…format.c (GH-151846) (#151865)

gh-151845: Fix formatfloat() return-value contract in unicode_format.c (GH-151846)

Fix formatfloat() return-value contract in unicode_format.c
(cherry picked from commit c2661e6)

Co-authored-by: AN Long <aisk@users.noreply.github.com>
@StanFromIreland

StanFromIreland commented Jun 21, 2026

Copy link
Copy Markdown
Member

@aisk feel free to remove the labels if a backport is unsuitable/not worth it.

@StanFromIreland StanFromIreland removed needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Jun 21, 2026
@aisk

aisk commented Jun 22, 2026

Copy link
Copy Markdown
Member Author

@aisk feel free to remove the labels if a backport is unsuitable/not worth it.

TIL, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sobolevn sobolevn sobolevn approved these changes

Assignees

@sobolevn sobolevn

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@aisk @sobolevn @StanFromIreland